Heavyweight Drunk Trait + Drunk Traits Rework #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
SimpleStation14
changed the title
|
before i undraft this im actually going to move |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
DangerRevolution
requested review from
DangerRevolution,
DEATHB4DEFEAT,
VMSolidus,
Pspritechologist,
OldDanceJacket and
Peptide90
DangerRevolution
approved these changes
Jul 12, 2024
Signed-off-by: VMSolidus <[email protected]>
|
Had to update it to include the new engine version, this was one I think where I had to very much by hand modify the merge conflict, rather than pick one. |
VMSolidus
approved these changes
Jul 12, 2024
SimpleStation14
added a commit
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the inverse of lightweight drunk, which makes you less susceptible to the effects of ethanol.
(more specifically, it halves the damage of alcohol and you need to drink twice as much to feel the effects in the first place)
To make the change happen,
LightweightDrunkcomponent was reworked to:I chose this route in particular, because the other option of multiplying the amount of ethanol gained from alcohols is nonsense.
TODO
TryMetabolizeReagentevent toMetabolizerSystem.csso aLightweightDrunkSystem.cscan listen to the event and multiply the effects of "Ethanol" specifically.Fix a minor spelling mistake that caused the trait condition to not show upMedia
Changelog
🆑